Updates from Koke Toggle Comment Threads | Keyboard Shortcuts

  • Koke 8:49 am on May 30, 2013 Permalink | Reply  

    From now on, posts about WordPress for iOS will go to http://make.wordpress.org/mobile/tag/ios/

    This blog is going to migrated over there soon so please start following/participating there

     

  • Koke 1:59 pm on March 25, 2013 Permalink
    Tags: 3.5.2   

    Submitting 3.5.2, did I miss something for the “What’s new?”

    • Disabled autosaves until they are more stable
    • Fixed bug where the editor would stay on portrait when using iOS5
    • Fixed credential issues for WordPress.com blogs with custom domains
    • Fixed previews when email was used to log in
    • Improved Jetpack setup process
    • Improved Notification settings
    • Multiple crashes fixed
     

  • Koke 7:08 pm on February 7, 2013 Permalink  

    3.4.1 has been submitted:

    • ~70% of crashes fixed
    • Notification related bugfixes
    • Better previews and remote autosaving

    Full changelog

    Will keep testing it while it’s on review, and planning to submit 3.4.2 next week with fixes for Jetpack/Stats and credentials problems. Hopefully for good this time

     

  • Koke 1:21 pm on January 25, 2013 Permalink
    Tags:   

    Just a tip for working with XIB files: if you need a different XIB file for iPad don’t do this:

    NSString *nibName;
if (IS_IPAD)
  nibName = @"MyViewController-iPad";
else
  nibName = @"MyViewController";
MyViewController *vc = [[MyViewController alloc] initWithNibName:nibName bundle:nil];

    Just name the xib files:

    * MyViewController~iphone
    * MyViewController~ipad

    And initialise with

    MyViewController *vc = [[MyViewController alloc] init];
     

  • Koke 1:20 pm on January 7, 2013 Permalink
    Tags: 3.3.1,   

    Getting ready for 3.3.1, full changelog

    Fixed crashes:

    • Crash on KVO (25% of crashes)
    • Crash: -[WPTableViewController viewWillAppear:] (10.28% of crashes)
    • Crash on Jetpack notifications (4.28% of crashes)
    • Crash: -[Media setProgress:] (0.89% of crashes)

    Fixed issues:

    • Don’t play sidebar sound if there’s a modal controller on top
    • Toolbar overlaps Remove Featured Image cancel button
    • Better upload cancels, specially for quick photo
    • Show an alert if user tries to post with failed media
    • Show an alert when adding a blog if credentials are good but user doesn’t have access to any blogs
    • Add a blog screen is too tall when logged in and you have no blogs
    • Shows a non-ui-blocking message when there are no results for posts, pages, or comments
    • Try to authenticate in order to show featured images in post settings for blogs marked private
    • Make sure we keep custom more text
    • If geotagging is enabled but location services are disabled prompt the user to enable them
    • Fixes toolbar button enabled states after picking media
    • Fix a problem on blogs with posts imported from tumblr, where posts have high IDs
    • Enable update button after removing media
    • If post is geotagged, continue to show the map information when geotagging is turned off
    • Give the video player a flexible height so we don’t loose the controls when we rotate
    • Post editor eats non breaking spaces and spits out semi-colons
    • Comments list can show wrong status
    • Avoid crashing on empty responses (0.41% of crashes)
    • App can show the sign up page instead of the create new blog page
    • Tapping on a long post doesn’t open editor
    • Typekit fonts not shown in Preview

    Updated translation originals at http://translate.wordpress.org/projects/ios/dev

    I’ll be testing today and submit real soon

     

  • Koke 12:54 pm on January 3, 2013 Permalink
    Tags: notifications, oauth2   

    When the user removes access to the app via wp.com settings we can use the username/password to get a new token, so I did that in ff3988a091.

    But, since I can’t think of another scenario for an “invalid_token” error than the user tapping that “Remove Access” button, I’m wondering if the expected behaviour would be to sign out and remove that account’s blogs from the app.

    Another one of those things that would be easier once we have an account model ;)

     

  • Koke 11:41 am on December 13, 2012 Permalink
    Tags: , UITableViewController   

    Table reminder: if a view controller defines it’s own table, it’s probably doing it wrong. If a view controller uses tables, almost every time it should be a subclass of UITableViewController. Doing that, you get a few things for free, in summary:

    • No need to create a .xib or the table view if the view only contains a table
    • Automatically sets delegate and dataSource to self
    • When the table view is about to appear the first time it’s loaded, the table-view controller reloads the table view’s data.
    • Clears table selection every time the table view is displayed.
    • When the table view has appeared, the controller flashes the table view’s scroll indicators.
    • It implements the superclass method setEditing:animated: so that if a user taps an Edit|Done button in the navigation bar, the controller toggles the edit mode of the table.

    There are a few places with potentially unnecessary code:

    ~/automattic/WordPress-iOS (notifications-wptable ✘)✭ ᐅ grep -rl --exclude-dir=Vendor '^@property.*UITableView\b' *                                 
Classes/AddUsersBlogsViewController.h
Classes/EditSiteViewController.h
Classes/JetpackSettingsViewController.h
Classes/NotificationsCommentDetailViewController.h
Classes/NotificationsFollowDetailViewController.h
Classes/NotificationsTableViewDatasource.h
Classes/PostMediaViewController.h
Classes/SidebarViewController.h
Classes/XMLSignupViewController.h
     

    • Koke 11:41 am on December 13, 2012 Permalink | Reply

    • Robert 4:53 pm on December 13, 2012 Permalink | Reply

      I don’t think NotificationsTableViewDatasource.h is actually being used so that can be deleted. NotificationsCommentDetailViewController.h doesn’t really use a UITableView in the “standard” way. For one, the UITableView is not the root view of the controller. The only bullet item it would benefit from seems to be:

      Automatically sets delegate and dataSource to self

      But that’s taken care of in the .xib.

      • Koke 5:27 pm on December 13, 2012 Permalink | Reply

        But that’s taken care of in the .xib.

        But you don’t need the .xib :)

        • Robert 5:59 pm on December 13, 2012 Permalink | Reply

          Subclassing UITableViewController only works if the view is also the tableView. I just gave it a go and it complains about the root view not being a UITableView and then crashes. The way NotificationsCommentDetailViewController is set up, the view is not a UITableView.

          • Koke 6:01 pm on December 13, 2012 Permalink | Reply

            Yeah, this seems to be one of those few cases :)
            I remember having to ditch UITableViewController somewhere else because tableHeaderView wasn’t enough to do the custom UI

            • Robert 6:06 pm on December 13, 2012 Permalink | Reply

              If there where a [UITableView tableHeaderViewDoesNotScroll] property that would allow you to fix the tableHeaderView to the top of the table I think it would take care of most of those customizations.

          • Dan 6:11 pm on December 13, 2012 Permalink | Reply

            I did the same for NotifcationsFollowDetailViewController because it needs a custom header that doesn’t scroll, but also has another header view that should scroll with the content. I couldn’t get it to work properly using a UITableViewController.

            • Robert 6:15 pm on December 13, 2012 Permalink | Reply

              Yeah, that’s the same issue I had, specifically for the note header view.

  • Koke 11:29 am on November 23, 2012 Permalink
    Tags: ssl   

    I added support for self-signed/invalid SSL certificates in [3700]

    Does anyone have a device with 4.3 to test that it works there too?

     

    • Koke 12:22 pm on November 23, 2012 Permalink | Reply

      Never mind, current deployment version is 5.0

    • Joseph Scott 5:45 pm on November 23, 2012 Permalink | Reply

      Bummer that iOS won’t remember the approval of the cert, but this is better than nothing. Thank you!

      • Koke 8:21 pm on November 23, 2012 Permalink | Reply

        Yeah, we don’t get any kind of certificate identifier, but we can get the raw DER data. Processing that is probably too much, but maybe we can store a hash and check that on the next session

  • Koke 4:06 pm on November 21, 2012 Permalink
    Tags:   

    Looking for trac workflow ideas. Since we’re moving to a feature based development, how should we manage tickets and milestones?

    Current problems:

    • 3.3 milestone has a lot of tickets related to notifications and visual editor
    • Trac has no bulk ticket management, so it’s a pain to move them one by one every time a feature is pushed back
    • Once a version is released, it’s nice to have every ticket fixed in the right milestone as reference for changes in that version

    In summary, considering that 3.3 is going to be Sounds + bugfixes, I’m having a hard time figuring out what’s important by looking at http://ios.trac.wordpress.org/query?status=assigned&status=new&status=accepted&status=reopened&group=status&milestone=3.3

    How do we manage this better for future releases/features?

     

    • Daniel Bachhuber 6:33 am on November 22, 2012 Permalink | Reply

      Trac has no bulk ticket management, so it’s a pain to move them one by one every time a feature is pushed back

      There’s a bulk ticket management plugin you can install. We have it for VIP Review Trac. @nbachiyski knows more.

    • Koke 12:27 pm on November 22, 2012 Permalink | Reply

      Until we get bulk management, I got this user style: https://gist.github.com/4130919

    • Koke 2:37 pm on November 22, 2012 Permalink | Reply

      I’m thinking of replacing the priorities list with this:

      • Security
      • Crash
      • Major: bugs that can cause data loss/corruption
      • Minor: bugs that generate confusion
      • Wishlist: everything else.

      Not sure about what kind of ‘defects’ would go into wishlist, but it’d be the priority for enhancement tickets.

      Thoughts?

      • Isaac Keyet 6:59 am on November 26, 2012 Permalink | Reply

        Not opposed to doing these, but we should change them across all the mobile projects if we do. It would probably make more sense to keep calling the lowest priority items “trivial” if we’re keeping “major” and “minor” though – but it’s just wording. Doesn’t matter all that much.

      • Brad 3:28 pm on November 27, 2012 Permalink | Reply

        I think there should still be a “blocker for release” priority. Then we should make sure all blocker priority items are closed before a release.

    • Koke 3:19 pm on November 22, 2012 Permalink | Reply

      Some new reports after the 3.3 milestone cleanup:

      • {16} Next Release: now uses the ‘Next Release’ milestone. Not so useful for planning, but still there
      • {18} Features in development: tickets assigned to components ‘Notifications’ and ‘Visual Editor’. Should be updated for future features
      • {19} Open defects: list of all defects grouped by priority, showing age, last time updated, and keywords

  • Koke 11:48 am on November 12, 2012 Permalink  

    Just released 3.2.1

    What’s new:

    • Improved login for Jetpack Stats
    • Fixed multiple crashes
    • Updated translations: German, Hebrew, Croatian, Hungarian, Italian, Norwegian, Dutch, Chinese

    Full changelog

     

← Older posts

c
compose new post
j
next post/next comment
k
previous post/previous comment
r
reply
e
edit
o
show/hide comments
t
go to top
l
go to login
h
show/hide help
shift + esc
cancel
Follow

Get every new post delivered to your Inbox.

Join 74 other followers