Can I get a code review of r4126? Want to make sure I’m not breaking something else with the sidebar 
Updates from Dan Toggle Comment Threads | Keyboard Shortcuts
-
Dan
-
Dan
I cleaned up the 3.2 roadmap a bit but there’s still ~60 tickets in there as they all looked like worthwhile issues that should be looked at if we have time. For now, focus on the tickets that have the enhancement type, and if there’s time focus on all of the others.
-
Dan
Do you think the panel interface would still work on a smaller, 7.85″ display?
-
Eric
I think the panels in general would still work. It might make sense to let individual detail panels slide all the way to the left side’s offset to get the best usage of space, especially in portrait orientation. Maybe the wide panels would need some attention too.
-
Brad
We might have to revert to the iPhone panels depending on how the screen space feels. I’d hate for the iPad panels to feel extremely cluttered.
-
-
Dan
Here’s the dev chat summary for this week. We discussed more than WPiOS this week but since we don’t have a mobile p2 yet I will just put all of the notes here:
WordPress for iOS
- We celebrated the submission of 3.1 to the app store!
- We chatted about what needs to be done for 3.1.1, and how it may impact the 3.2 timeline. In order to squash the bugs in the 3.1.1 roadmap we will probably need to push back the 3.2 submission until the 2nd or 3rd week of September.
- We figured a 3.1.2 release will also be important to prepare once we start getting feedback from users on 3.1 when it is out in the wild. Less people will have to work on this release though, so we can put some people on 3.2 dev while others hammer out the 3.1.2 fixes.
- We agreed on the feature list for 3.2, with a wild card being contentEditable. @irbrad is going to see if it is feasible to include in 3.2 and will report his findings at next week’s meeting.
Other Stuff
- We thought it would be a good idea to add featured image and gallery support to all of the major apps at relatively the same time, perhaps around the same time as the 3.2 launch.
- We discussed the upcoming BB 10 release, and @daniloercoli mentioned he has a proof of concept of a WP app that uses WebWorks (HTML5).
- The WP7 app needs some lovin’. A few of us volunteered to do a dev iteration on the app once we get out of the WPiOS madness. Discussed adding local draft support and making sure it runs well on Windows Phone 8.
-
Isaac Keyet
For future reference: based on this discussion I updated the WPWindowsPhone 1.7 milestone: http://windowsphone.trac.wordpress.org/query?group=status&milestone=1.7
-
Dan
Fun facts about WPiOS 3.1:
513 commits
181 tickets closed
8 contributors (most ever!), who were busy little bees:Well done everybody!
-
Dan
I’ve found it quite difficult to round the corners of one side of a panel and have a drop shadow as well. What I’ve done in r2873 is only add shadows to the 2nd panel and beyond. This preserves the rounded corners like we want them, except for the corners on the right of the last panel.
It’s pretty much a match of how the twitter app works now, except they are able to somehow add a shadow and the right rounded corners to the last view. I’m thinking they might actually be using an image or something for the rounded corners instead of using a layer mask.
-
Jorge Bernal
It seems CALayer mask property includes shadows in the masking. If there’s not another way of doing a custom shaped view:
- We could try with sublayers (we already have a wrapper view)
- I’d rather have shadows than rounded corners
-
Dan
I wasn’t having much luck with the sublayers, but maybe I wasn’t applying it to the wrapper view. I’ll keep poking around.
I agree that the shadows are more important, but both would be awesome
-
-
Dan
I’ve seen instance variables throughout the app, some with _name, others with name_, and others with no underscores at all. Can we decide on a standard?
-
Jorge Bernal
I’d say _foo for all instance variables, and foo for local variables. foo_ in ObjC looks just weird.
As I put in the coding style guide, if it’s a 3rd party library, use the library style, even if it sucks
-
Dan
Agreed, I think _foo catches the eye easier when you’re browsing the code.
-
Jorge Bernal
Plus, you never get the “Local declaration of ‘tableView’ hides instance variable” problem
-
-
-
-
Dan
A tribute to the first few lines of code in the app:
if (DeviceIsPad()) [UIViewController youWillAutorotateOrYouWillDieMrBond];
-
Isaac Keyet
-
Jorge Bernal
I’ve been wanting to get rid of that for a while but I don’t have the heart to kill Mr Bond
-
Dan
It is kinda cheesy.
-
-
-
Dan
My wife was creating a post on her iPhone and thought if she left the app she would be able to come back to her post later and finish it up. Since she was on a new draft in the post editor, the OS killed the app when more resources were needed and she lost the post.
Maybe we can add a draft save when the app enters the background when in the post editor?
-
Jorge Bernal
It should be the case, kind of. If you create a draft, I believe every time you end editing a field it should get stored.
We could listen to UIApplicationWillResignActiveNotification and UIApplicationDidEnterBackgroundNotification just in case. Maybe memory warning notifications too.
But if the draft was completely gone (as opposed to just the latest changes), it’s a bug.
-
Dan
OK, I’ll try to reproduce it on my device. I don’t think she ever completed editing the field, just left it in the full screen content editing mode.
-
-
Jorge Bernal
Easy bug, we’re missing a [self.post autosave] in textViewDidEndEditing:
I’ll add that when I’m done merging the 2.9 branch -
Jorge Bernal
Added #982-ios, it shouldn’t take long but a ticket is more reliable to keeping a tab open on the browser as a reminder
-
Brad Angelcyk
I added a local save into applicationDidEnterBackground: to resolve this. That way if the user switches out while the textView is still in edit, the content will be saved.
-
Dan
Boom!
-
-
-
-
Dan
I went to upload some images and when…
I went to upload some images, and when the custom dialog popped up, I also received the location allow dialog at the same moment. I couldn’t tap on anything until I switched to a different app, and then could respond to the location dialog.
-
Gloopy
We have had 3 customers now tell us about this
deffo a bug
-
Koke 2:25 pm on February 27, 2013 Permalink |
Looks good to me, but I’m not at my best today