Making a note for us to review the patch from MarcoZ at:
Recent Updates Toggle Comment Threads | Keyboard Shortcuts
-
Eric
-
Koke
Submitting 3.5.2, did I miss something for the “What’s new?”
- Disabled autosaves until they are more stable
- Fixed bug where the editor would stay on portrait when using iOS5
- Fixed credential issues for WordPress.com blogs with custom domains
- Fixed previews when email was used to log in
- Improved Jetpack setup process
- Improved Notification settings
- Multiple crashes fixed
-
Koke
Full changelog: https://gist.github.com/koke/5238734
-
Paolo
Just a heads-up that after updating to 3.5.1 everything was working fine excepted the reader, remaining blank. I had to log out and log in again into my WordPress.com account to get it working again.
-
Dan
Can I get a code review of r4126? Want to make sure I’m not breaking something else with the sidebar
-
Koke
Looks good to me, but I’m not at my best today
-
-
Koke
3.4.1 has been submitted:
- ~70% of crashes fixed
- Notification related bugfixes
- Better previews and remote autosaving
Will keep testing it while it’s on review, and planning to submit 3.4.2 next week with fixes for Jetpack/Stats and credentials problems. Hopefully for good this time
-
Koke
Just a tip for working with XIB files: if you need a different XIB file for iPad don’t do this:
NSString *nibName; if (IS_IPAD) nibName = @"MyViewController-iPad"; else nibName = @"MyViewController"; MyViewController *vc = [[MyViewController alloc] initWithNibName:nibName bundle:nil];
Just name the xib files:
* MyViewController~iphone
* MyViewController~ipadAnd initialise with
MyViewController *vc = [[MyViewController alloc] init];
-
Koke
Getting ready for 3.3.1, full changelog
Fixed crashes:
- Crash on KVO (25% of crashes)
- Crash: -[WPTableViewController viewWillAppear:] (10.28% of crashes)
- Crash on Jetpack notifications (4.28% of crashes)
- Crash: -[Media setProgress:] (0.89% of crashes)
Fixed issues:
- Don’t play sidebar sound if there’s a modal controller on top
- Toolbar overlaps Remove Featured Image cancel button
- Better upload cancels, specially for quick photo
- Show an alert if user tries to post with failed media
- Show an alert when adding a blog if credentials are good but user doesn’t have access to any blogs
- Add a blog screen is too tall when logged in and you have no blogs
- Shows a non-ui-blocking message when there are no results for posts, pages, or comments
- Try to authenticate in order to show featured images in post settings for blogs marked private
- Make sure we keep custom more text
- If geotagging is enabled but location services are disabled prompt the user to enable them
- Fixes toolbar button enabled states after picking media
- Fix a problem on blogs with posts imported from tumblr, where posts have high IDs
- Enable update button after removing media
- If post is geotagged, continue to show the map information when geotagging is turned off
- Give the video player a flexible height so we don’t loose the controls when we rotate
- Post editor eats non breaking spaces and spits out semi-colons
- Comments list can show wrong status
- Avoid crashing on empty responses (0.41% of crashes)
- App can show the sign up page instead of the create new blog page
- Tapping on a long post doesn’t open editor
- Typekit fonts not shown in Preview
Updated translation originals at http://translate.wordpress.org/projects/ios/dev
I’ll be testing today and submit real soon
-
Koke
When the user removes access to the app via wp.com settings we can use the username/password to get a new token, so I did that in ff3988a091.
But, since I can’t think of another scenario for an “invalid_token” error than the user tapping that “Remove Access” button, I’m wondering if the expected behaviour would be to sign out and remove that account’s blogs from the app.
Another one of those things that would be easier once we have an account model
-
Koke
Table reminder: if a view controller defines it’s own table, it’s probably doing it wrong. If a view controller uses tables, almost every time it should be a subclass of
UITableViewController. Doing that, you get a few things for free, in summary:- No need to create a .xib or the table view if the view only contains a table
- Automatically sets delegate and dataSource to self
- When the table view is about to appear the first time it’s loaded, the table-view controller reloads the table view’s data.
- Clears table selection every time the table view is displayed.
- When the table view has appeared, the controller flashes the table view’s scroll indicators.
- It implements the superclass method setEditing:animated: so that if a user taps an Edit|Done button in the navigation bar, the controller toggles the edit mode of the table.
There are a few places with potentially unnecessary code:
~/automattic/WordPress-iOS (notifications-wptable ✘)✭ ᐅ grep -rl --exclude-dir=Vendor '^@property.*UITableView\b' * Classes/AddUsersBlogsViewController.h Classes/EditSiteViewController.h Classes/JetpackSettingsViewController.h Classes/NotificationsCommentDetailViewController.h Classes/NotificationsFollowDetailViewController.h Classes/NotificationsTableViewDatasource.h Classes/PostMediaViewController.h Classes/SidebarViewController.h Classes/XMLSignupViewController.h
-
Koke
-
Robert
I don’t think
NotificationsTableViewDatasource.his actually being used so that can be deleted.NotificationsCommentDetailViewController.hdoesn’t really use a UITableView in the “standard” way. For one, theUITableViewis not the root view of the controller. The only bullet item it would benefit from seems to be:Automatically sets delegate and dataSource to self
But that’s taken care of in the
.xib.-
Koke
But that’s taken care of in the .xib.
But you don’t need the
.xib -
Robert
Subclassing
UITableViewControlleronly works if theviewis also thetableView. I just gave it a go and it complains about the root view not being aUITableViewand then crashes. The wayNotificationsCommentDetailViewControlleris set up, theviewis not aUITableView.-
Koke
Yeah, this seems to be one of those few cases
I remember having to ditch UITableViewController somewhere else because tableHeaderView wasn’t enough to do the custom UI-
Robert
If there where a [UITableView tableHeaderViewDoesNotScroll] property that would allow you to fix the tableHeaderView to the top of the table I think it would take care of most of those customizations.
-
-
Dan
I did the same for NotifcationsFollowDetailViewController because it needs a custom header that doesn’t scroll, but also has another header view that should scroll with the content. I couldn’t get it to work properly using a UITableViewController.
-
Robert
Yeah, that’s the same issue I had, specifically for the note header view.
-
-
-
-
-
Eric
Since the in-app-sounds branch has been merged to trunk I’ve deleted it. While I was at it, in the name of tidying up a bit, I’ve removed a few other branches that were either empty or obsolete:
I thought there might be something we might want to come back to in the flurry and hybrid branches so I’ve left them alone. I’m not sure what the sideswipe branch was for so I left it as well.
I wanted to remove the numbered version branches since we have tags for all our releases, but it looks like the revisions don’t match their counterparts under tags so I held off. Is there a reason to keep these?
MarcoZ is discussing. 
MarcoZ 7:17 pm on April 8, 2013 Permalink |
Thanks Eric!
Note that I am currently also struggling with another issue that warrants a separate ticket I think, and which I would definitely need some help on. That is that the side bar leaks through to VoiceOver from the background. On the iPhone, for example, in-between the controls when viewing a comment. On the iPad, too, once the comments or article list slides to the left to make room for the actual comment or similar on the right.
On the iPad, there is also even more of a problem there because there is no obvious way for a blind person to slide the list back to the right. I will file issue tickets for these and would need advice or even help in coding this.